Let 'size_of' always be multiple of 'min_align_of' #20611
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
simnalamburt
changed the title
size_of always be multiple of min_align_of
| // whatever. Rounds up to the nearest byte though, so if you have a 1-bit | ||
| // with the type. Not junk, accidentally-damaged words, or whatever. | ||
| // Note that padding of the type will be included for structs, but not for the | ||
| // other types. (i.e. SIMD types) |
There was a problem hiding this comment.
nit: the period should be at the end of the sentence, after the term in braces.
There was a problem hiding this comment.
Like this?
Note that padding of the type will be included for structs, but not for the other types (i.e. SIMD types).
|
😢 |
|
Could you test to see if this fixes #17170 as well? |
|
@huonw, I tested it and it couldn't. It looks like a different issue. Let me explain it more at there |
|
YEAHHH YEE |
This PR fixes the issue rust-lang#20460, and it doesn't touch any existing behavior except the bug of the SIMD types. Closes rust-lang#20460.
This PR fixes the issue #20460, and it doesn't touch any existing behavior except the bug of the SIMD types.
Closes #20460.